lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 055/131] coresight: coresight_unregister() function cleanup
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit fae54158792aec705620bdc3938d342879204f0c ]

    In its current form the code never frees csdev->refcnt allocated
    in coresight_register(). There is also a problem with csdev->conns
    that is freed before device_unregister() rather than in the device
    release function.

    This patch addresses both issues by moving kfree(csdev->conns) to
    coresight_device_release() and freeing csdev->refcnt, also in
    the same function.

    Reported-by: Rabin Vincent <rabin@rab.in>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwtracing/coresight/coresight.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
    index 84fc60318f79..a7d1edbf3340 100644
    --- a/drivers/hwtracing/coresight/coresight.c
    +++ b/drivers/hwtracing/coresight/coresight.c
    @@ -484,6 +484,8 @@ static void coresight_device_release(struct device *dev)
    {
    struct coresight_device *csdev = to_coresight_device(dev);

    + kfree(csdev->conns);
    + kfree(csdev->refcnt);
    kfree(csdev);
    }

    @@ -716,7 +718,6 @@ EXPORT_SYMBOL_GPL(coresight_register);

    void coresight_unregister(struct coresight_device *csdev)
    {
    - kfree(csdev->conns);
    device_unregister(&csdev->dev);
    }
    EXPORT_SYMBOL_GPL(coresight_unregister);
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-04-01 19:49    [W:4.447 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site