lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 066/131] coresight: "DEVICE_ATTR_RO" should defined as static.
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit bf16e5b8cdeabc1fe6565af0be475bb2084dc388 ]

    "DEVICE_ATTR_RO(name)" should be defined as static. And
    there is an unnecessary space at the front of the code.

    The sparse tool output logs as the following:
    coresight-etm4x.c:2224:1: warning: symbol 'dev_attr_trcoslsr' was
    not declared. Should it be static?
    coresight-etm4x.c:2225:1: warning: symbol 'dev_attr_trcpdcr' was
    not declared. Should it be static?
    coresight-etm4x.c:2226:1: warning: symbol 'dev_attr_trcpdsr' was
    not declared. Should it be static?
    And the smatch tool output logs as the following:
    of_coresight.c:89 of_coresight_alloc_memory() warn:
    inconsistent indenting

    Signed-off-by: Eric Long <eric.long@linaro.org>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
    drivers/hwtracing/coresight/of_coresight.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
    index a6707642bb23..1ec6798b21e8 100644
    --- a/drivers/hwtracing/coresight/coresight-etm4x.c
    +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
    @@ -2219,7 +2219,7 @@ static ssize_t name##_show(struct device *_dev, \
    return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
    readl_relaxed(drvdata->base + offset)); \
    } \
    -DEVICE_ATTR_RO(name)
    +static DEVICE_ATTR_RO(name)

    coresight_simple_func(trcoslsr, TRCOSLSR);
    coresight_simple_func(trcpdcr, TRCPDCR);
    diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
    index 7d2bb1549608..fb7597b1c66f 100644
    --- a/drivers/hwtracing/coresight/of_coresight.c
    +++ b/drivers/hwtracing/coresight/of_coresight.c
    @@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev,
    return -ENOMEM;

    /* Children connected to this component via @outports */
    - pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
    + pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
    sizeof(*pdata->child_names),
    GFP_KERNEL);
    if (!pdata->child_names)
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-04-01 19:48    [W:6.292 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site