lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier
On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote:
>
> On 4/1/2019 8:07 PM, Marcelo Schmitt wrote:
> > Add SPDX identifier of GPL-2.0 for the ad9832 driver.
> >
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > ---
> > drivers/staging/iio/frequency/ad9832.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index 50a583020072..d8d4a7936275 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -1,9 +1,8 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> FYI
>
> Use C notations here as per https://lkml.org/lkml/2019/2/13/570.
>
> <https://lkml.org/lkml/2019/2/13/570>
>
> Once you fix it then you can take mine
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Did you read the documentation about how to put a proper SPDX line in
the kernel documentation? For .c files, you have to use "//", not "/* */"

Please read:
Documentation/process/license-rules.rst
and see the section "Style" for all of the details.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-04-01 19:40    [W:0.079 / U:14.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site