lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Staging: comedi: drivers: pcl818: Fixed a coding style error.
On Mon, Apr 01, 2019 at 10:01:30AM -0400, Will Cunningham wrote:
> Removed unnecessary parentheses.
>
> Signed-off-by: Will Cunningham <wjcunningham7@gmail.com>
> ---
> Changes in v2:
> - Removed a typo from the commit message.
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 0af5315d4357..da5d53a288f7 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> pcl818_alloc_dma(dev, it->options[2]);
>
> /* use 1MHz or 10MHz oscilator */
> - if ((it->options[3] == 0) || (it->options[3] == 10))
> + if (it->options[3] == 0 || it->options[3] == 10)

Again, no, the original is best.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-04-01 17:01    [W:0.033 / U:13.928 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site