lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arm64: dts: qcom: Add Lenovo Miix 630
Hi Lee.

On Mon, Apr 1, 2019 at 4:52 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 26 Mar 2019, Jeffrey Hugo wrote:
>
> > This adds the initial DT for the Lenovo Miix 630 laptop. Supported
> > functionality includes USB (host), microSD-card, keyboard, and trackpad.
> >
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > arch/arm64/boot/dts/qcom/msm8998-cls.dtsi | 278 ++++++++++++++++++
>
> What is cls?

Clamshell. I left a comment in the file that is intended to clarify
this. If one does some digging, they should find a fair number of
"cls" references within the firmware and windows.

>
> How much of this will be reusable with the other laptops?

The intent is that all the common stuff, which I expect is >90%, is in
the cls.dtsi so that we don't have multiple copies of it. Variances,
such as the SD detect GPIO stuff we've discovered would be in the
individual dtb. Or at-least, that is the idea. I'm open to
suggestions.

I'm unable to post dts files based on the HP/Asus at this time, but
hopefully that changes soon. Otherwise, Its my goal that this
provides a good framework for adding those devices.

>
> > .../boot/dts/qcom/msm8998-lenovo-miix-630.dts | 33 +++
> > 3 files changed, 312 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8998-cls.dtsi
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2019-04-01 16:14    [W:0.059 / U:17.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site