lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] i2c: isch: Remove unnecessary acpi.h include
On Mon, Mar 25, 2019 at 1:37 PM <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
> convert i2c-isch to platform_device") removed the use of
> acpi_check_region() but not the include.
>
> Remove the now-unnecessary include of <linux/acpi.h>. No functional change
> intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Added

Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

on my local branch.

Jean, would you like me to repost this with the updates? I assume you
will merge this (just based on get_maintainer.pl)?

> ---
> drivers/i2c/busses/i2c-isch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
> index 5c754bf659e2..f64c1d72f73f 100644
> --- a/drivers/i2c/busses/i2c-isch.c
> +++ b/drivers/i2c/busses/i2c-isch.c
> @@ -30,7 +30,6 @@
> #include <linux/ioport.h>
> #include <linux/i2c.h>
> #include <linux/io.h>
> -#include <linux/acpi.h>
>
> /* SCH SMBus address offsets */
> #define SMBHSTCNT (0 + sch_smba)
> --
> 2.21.0.392.gf8f6787159e-goog
>

\
 
 \ /
  Last update: 2019-04-01 15:51    [W:0.083 / U:66.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site