lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages
Date
Dear Yannick,
Fully agree with this approach,

Acked-by: Philippe Cornu <philippe.cornu@st.com>

Philippe :-)

On 3/29/19 4:49 PM, Yannick Fertré wrote:
> From: Philippe Cornu <philippe.cornu@st.com>
>
> Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> inform the user in case of fifo underruns or
> transfer errors.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..15d8a02 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
>
> mutex_lock(&ldev->err_lock);
> if (ldev->error_status & ISR_FUIF) {
> - DRM_DEBUG_DRIVER("Fifo underrun\n");
> + DRM_WARN("ltdc fifo underrun: please verify display mode\n");
> ldev->error_status &= ~ISR_FUIF;
> }
> if (ldev->error_status & ISR_TERRIF) {
> - DRM_DEBUG_DRIVER("Transfer error\n");
> + DRM_WARN("ltdc transfer error\n");
> ldev->error_status &= ~ISR_TERRIF;
> }
> mutex_unlock(&ldev->err_lock);
>
\
 
 \ /
  Last update: 2019-04-01 11:21    [W:0.029 / U:32.232 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site