lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code
From
Date

On 4/1/2019 10:59 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-snvs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
> index ce73eab..e0edd594 100644
> --- a/drivers/rtc/rtc-snvs.c
> +++ b/drivers/rtc/rtc-snvs.c
> @@ -272,7 +272,6 @@ static const struct regmap_config snvs_rtc_config = {
> static int snvs_rtc_probe(struct platform_device *pdev)
> {
> struct snvs_rtc_data *data;
> - struct resource *res;
> int ret;
> void __iomem *mmio;
>
> @@ -284,9 +283,8 @@ static int snvs_rtc_probe(struct platform_device *pdev)
>
> if (IS_ERR(data->regmap)) {
> dev_warn(&pdev->dev, "snvs rtc: you use old dts file, please update it\n");
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
Remove this blank line.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> - mmio = devm_ioremap_resource(&pdev->dev, res);
> + mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmio))
> return PTR_ERR(mmio);
>

\
 
 \ /
  Last update: 2019-04-01 09:58    [W:0.044 / U:13.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site