lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] signal: annotate implicit fall through
From
Date
[+cc Andrew]

On 3/13/19 3:27 PM, Mathieu Malaterre wrote:
> ping ?
>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Maybe Andrew can take this?

Thanks
--
Gustavo

> On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>>
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> this place in the code produced a warning (W=1).
>>
>> This commit remove the following warning:
>>
>> kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> kernel/signal.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index e1d7ad8e6ab1..aa7a507757d7 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>> */
>> if (!sid || sid == task_session(current))
>> break;
>> + /* fall through */
>> default:
>> return -EPERM;
>> }
>> --
>> 2.19.2
>>

\
 
 \ /
  Last update: 2019-04-01 21:53    [W:0.052 / U:62.676 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site