lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: [PATCH] i2c: isch: Remove unnecessary acpi.h include
On Mon, Apr 1, 2019 at 9:08 AM Wolfram Sang <wsa@the-dreams.de> wrote:
>
>
> > > From: Bjorn Helgaas <bhelgaas@google.com>
> > >
> > > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > > <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
> > > convert i2c-isch to platform_device") removed the use of
> > > acpi_check_region() but not the include.
> > >
> > > Remove the now-unnecessary include of <linux/acpi.h>. No functional change
> > > intended.
> > >
> > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Added
> >
> > Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
> > Reviewed-by: Jean Delvare <jdelvare@suse.de>
> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> >
> > on my local branch.
> >
> > Jean, would you like me to repost this with the updates? I assume you
> > will merge this (just based on get_maintainer.pl)?
>
> I will apply it, now that it has Jean's Rev-by. I assume this is
> for-next material despite the Fixes tag?

Definitely for-next material, not for the current release. Jean
suggested the Fixes tag, I think since it's related to a specific
commit and could be backported together with that commit.

Should there be a MAINTAINERS update to clarify who applies patches to
drivers/i2c/busses/i2c-isch.c? Right now, get_maintainers.pl doesn't
mention you (Wolfram).

Patch with tags attached in case it's useful to you (sorry, I'm
saddled with gmail right now and can't include it inline).
From 36fbdab89f5b8aa2d3616bd289e2c695fd3c0f9b Mon Sep 17 00:00:00 2001
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Tue, 30 Oct 2018 14:12:36 -0500
Subject: [PATCH] i2c: isch: Remove unnecessary acpi.h include

54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
<linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
convert i2c-isch to platform_device") removed the use of
acpi_check_region() but not the include.

Remove the now-unnecessary include of <linux/acpi.h>. No functional change
intended.

Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
---
drivers/i2c/busses/i2c-isch.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 5c754bf659e2..f64c1d72f73f 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -30,7 +30,6 @@
#include <linux/ioport.h>
#include <linux/i2c.h>
#include <linux/io.h>
-#include <linux/acpi.h>

/* SCH SMBus address offsets */
#define SMBHSTCNT (0 + sch_smba)
--
2.21.0.392.gf8f6787159e-goog
\
 
 \ /
  Last update: 2019-04-01 21:37    [W:0.089 / U:0.752 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site