Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices | Date | Mon, 01 Apr 2019 20:31:58 +0200 |
| |
Hi Leonidas,
Am Montag, 1. April 2019, 20:18:40 CEST schrieb Leonidas P. Papadakos: > From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= <ayufan@ayufan.eu> > > Some rockchip boards exhibit an issue where tx checksumming does not work with > packets larger than 1498. > > This is bad for network stability. > > The previous approach was using force_thresh_dma_mode in the board dts, which > does more than we need. > > Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 3031f2bf1..807cf5826 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -519,6 +519,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) > pr_warn("force_sf_dma_mode is ignored if force_thresh_dma_mode is set."); > } > > + plat->bugged_tx_coe = of_property_read_bool(np, "rockchip,bugged_tx_coe"); > +
you're adding a new devicetree property, so please (1) also update the binding doc in Documentation/devicetree/bindings/net/rockchip-dwmac.txt (2) Cc devicetree maintainers and lists (via get_maintainer.pl once you've added the binding change) to let them look at it.
Thanks Heiko
> of_property_read_u32(np, "snps,ps-speed", &plat->mac_port_sel_speed); > > plat->axi = stmmac_axi_setup(pdev); > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 4335bd771..60c411f43 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -162,6 +162,7 @@ struct plat_stmmacenet_data { > int pmt; > int force_sf_dma_mode; > int force_thresh_dma_mode; > + int bugged_tx_coe; > int riwt_off; > int max_speed; > int maxmtu; >
| |