lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tcp: fix a potential NULL pointer dereference in tcp_sk_exit
From
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 1 Apr 2019 02:23:39 -0700

> On Mon, Apr 1, 2019 at 1:05 AM dust.li <dust.li@linux.alibaba.com> wrote:
>>
>> From: Dust Li <dust.li@linux.alibaba.com>
>>
>> When tcp_sk_init() failed in inet_ctl_sock_create(),
>> 'net->ipv4.tcp_congestion_control' will be left
>> uninitialized, but tcp_sk_exit() hasn't check for
>> that.
>>
>> This patch add checking on 'net->ipv4.tcp_congestion_control'
>> in tcp_sk_exit() to prevent NULL-ptr dereference.
>>
>> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
>
> Fixes: 6670e1524477 ("tcp: Namespace-ify sysctl_tcp_default_congestion_control")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

This patch didn't make it to the list for whatever reason, but I applied it and
have it queued up for -stable.

Thanks.

\
 
 \ /
  Last update: 2019-04-01 20:06    [W:0.074 / U:0.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site