Messages in this thread Patch in this message | | | From | Kangjie Lu <> | Subject | [PATCH] memstick: fix a potential NULL pointer dereference | Date | Sat, 9 Mar 2019 01:59:17 -0600 |
| |
In case alloc_ordered_workqueue fails, the fix returns ENOMEM to avoid potential NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/memstick/core/ms_block.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index 82daccc9ea62..8e00de414567 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -2149,6 +2149,11 @@ static int msb_init_disk(struct memstick_dev *card) msb->usage_count = 1; msb->io_queue = alloc_ordered_workqueue("ms_block", WQ_MEM_RECLAIM); + if (!msb->io_queue) { + rc = -ENOMEM; + goto out_put_disk; + } + INIT_WORK(&msb->io_work, msb_io_work); sg_init_table(msb->prealloc_sg, MS_BLOCK_MAX_SEGS+1); -- 2.17.1
| |