lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net] rxrpc: Fix client call queueing, waiting for channel
From
From: David Howells <dhowells@redhat.com>
Date: Sat, 09 Mar 2019 00:29:58 +0000

> rxrpc_get_client_conn() adds a new call to the front of the waiting_calls
> queue if the connection it's going to use already exists. This is bad as
> it allows calls to get starved out.
>
> Fix this by adding to the tail instead.
>
> Also change the other enqueue point in the same function to put it on the
> front (ie. when we have a new connection). This makes the point that in
> the case of a new connection the new call goes at the front (though it
> doesn't actually matter since the queue should be unoccupied).
>
> Fixes: 45025bceef17 ("rxrpc: Improve management and caching of client connection objects")
> Signed-off-by: David Howells <dhowells@redhat.com>
> Reviewed-by: Marc Dionne <marc.dionne@auristor.com>

Applied and queued up for -stable, thanks David.

\
 
 \ /
  Last update: 2019-03-09 03:26    [W:0.037 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site