lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v1 4/5] scripts: checkpatch.pl: don't complain that debian/rules is executable
    From
    Date
    On Fri, 2019-03-08 at 13:44 +0100, Enrico Weigelt, metux IT consult wrote:
    > checkpatch.pl complains when adding executable "debian/rules",
    > obviously a false alarm. Therefore add an exception for that.

    This is predicated on a debian/ directory actually being added
    to the generic kernel tree.

    I'm not sure that's a good idea.

    As debian/ does not currently exist in the generic kernel source,
    I think this can be kept locally in their tree if they choose.

    > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    []
    > @@ -2576,6 +2576,7 @@ sub process {
    > if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
    > my $permhere = $here . "FILE: $realfile\n";
    > if ($realfile !~ m@scripts/@ &&
    > + $realfile !~ "debian/rules" &&
    > $realfile !~ /\.(py|pl|awk|sh)$/) {
    > ERROR("EXECUTE_PERMISSIONS",
    > "do not set execute permissions for source files\n" . $permhere);

    \
     
     \ /
      Last update: 2019-03-08 15:14    [W:4.433 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site