lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
From
Date
Hello

On 3/7/19 4:09 PM, Dan Murphy wrote:
> Introduce the Texas Instruments LM3532 White LED driver.
> The driver supports ALS configurability or manual brightness
> control.
>
> The driver also supports associating LED strings with specific
> control banks in a group or as individually controlled strings.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-lm3532.c | 595 +++++++++++++++++++++++++
> include/dt-bindings/leds/leds-lm3532.h | 72 +++
> 4 files changed, 678 insertions(+)
> create mode 100644 drivers/leds/leds-lm3532.c
> create mode 100644 include/dt-bindings/leds/leds-lm3532.h
>

After thinking about this dt header I am not happy about having it.
I am thinking of removing this file completely and doing some calculations in the driver
file for the impedance, averaging time and ramp times.

I would still like to get comments on the rest of the code but in v2 the dt bindings header will
go away.

Dan

<snip>
--
------------------
Dan Murphy

\
 
 \ /
  Last update: 2019-03-08 14:29    [W:0.084 / U:2.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site