lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 63/76] xhci: tegra: Prevent error pointer dereference
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thierry Reding <treding@nvidia.com>

    commit 0326ccb5feac6eac35ba6254260e2774277cd976 upstream.

    During initialization, the host and super-speed power domains will
    contain an ERR_PTR() encoded error code rather than being NULL. To
    avoid a crash, use a !IS_ERR_OR_NULL() condition during cleanup.

    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Fixes: 6494a9ad86de ("usb: xhci: tegra: Add genpd support")
    Cc: stable <stable@vger.kernel.org>
    Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
    Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/xhci-tegra.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/usb/host/xhci-tegra.c
    +++ b/drivers/usb/host/xhci-tegra.c
    @@ -941,9 +941,9 @@ static void tegra_xusb_powerdomain_remov
    device_link_del(tegra->genpd_dl_ss);
    if (tegra->genpd_dl_host)
    device_link_del(tegra->genpd_dl_host);
    - if (tegra->genpd_dev_ss)
    + if (!IS_ERR_OR_NULL(tegra->genpd_dev_ss))
    dev_pm_domain_detach(tegra->genpd_dev_ss, true);
    - if (tegra->genpd_dev_host)
    + if (!IS_ERR_OR_NULL(tegra->genpd_dev_host))
    dev_pm_domain_detach(tegra->genpd_dev_host, true);
    }


    \
     
     \ /
      Last update: 2019-03-08 14:06    [W:4.109 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site