lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 34/68] net: phy: phylink: fix uninitialized variable in phylink_get_mac_state
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Heiner Kallweit <hkallweit1@gmail.com>

    [ Upstream commit d25ed413d5e51644e18f66e34eec049f17a7abcb ]

    When debugging an issue I found implausible values in state->pause.
    Reason in that state->pause isn't initialized and later only single
    bits are changed. Also the struct itself isn't initialized in
    phylink_resolve(). So better initialize state->pause and other
    not yet initialized fields.

    v2:
    - use right function name in subject
    v3:
    - initialize additional fields

    Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
    Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/phy/phylink.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/net/phy/phylink.c
    +++ b/drivers/net/phy/phylink.c
    @@ -348,6 +348,10 @@ static int phylink_get_mac_state(struct
    linkmode_zero(state->lp_advertising);
    state->interface = pl->link_config.interface;
    state->an_enabled = pl->link_config.an_enabled;
    + state->speed = SPEED_UNKNOWN;
    + state->duplex = DUPLEX_UNKNOWN;
    + state->pause = MLO_PAUSE_NONE;
    + state->an_complete = 0;
    state->link = 1;

    return pl->ops->mac_link_state(ndev, state);

    \
     
     \ /
      Last update: 2019-03-08 14:04    [W:4.167 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site