lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression
From
Date

On 05.03.2019 15:26, Jiri Olsa wrote:
> On Fri, Mar 01, 2019 at 06:58:32PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>>
>> +static size_t record__process_comp_header(void *record, size_t increment)
>> +{
>> + struct compressed_event *event = record;
>> + size_t size = sizeof(struct compressed_event);
>> +
>> + if (increment) {
>> + event->header.size += increment;
>> + return increment;
>> + } else {
>> + event->header.type = PERF_RECORD_COMPRESSED;
>> + event->header.size = size;
>> + return size;
>> + }
>> +}
>> +
>> +static size_t record__zstd_compress(void *data, void *dst, size_t dst_size,
>
> we use the <name>__ to mark 'struct' related function,
> which supposed to be the first argument.. IMO zstd_compress
> will be fine in here

in v7.

~Alexey

>
> jirka
>

\
 
 \ /
  Last update: 2019-03-07 09:27    [W:0.151 / U:2.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site