lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings
From
Date
On 07/03/2019 12:45, Peter Zijlstra wrote:
> drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to hypercall_page() with UACCESS enabled
>
> Xen needs to do HV calls with AC=1 for hysterical raisins. Make the
> warning go away.

No, this is a hypercall with parameters passed through from user land
(Xen tools). So setting AC=1 is not related to hysterical reasons, but
to indicate that unprivileged buffers are okay here. So please change
the commit message to something like:

Some Xen hypercalls allow parameter buffers in user land, so they need
to set AC=1. Avoid the warning for those cases.

> XXX: arguably we should rename ANNOTATE_NOSPEC_ALTERNATIVE to
> ANNOTATE_IGNORE_ALTERNATIVE.
>
> Cc: andrew.cooper3@citrix.com
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Mind Cc-ing the maintainers of the code you are touching in future
patches?

With the commit message adjusted:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

\
 
 \ /
  Last update: 2019-03-07 13:23    [W:0.276 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site