Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 5 Mar 2019 14:21:11 -0800 | Subject | Re: [PATCH 2/2] ARM: drop -mauto-it |
| |
On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote: > > The assembler option -mauto-it is no longer a valid option. It has > been removed from the documentation in July 2009, which is well > before the release date of the currently supported binutils version > 2.20.
Do you by chance have a link to the relevant commit?
> > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 9561325c5201..ebf67bebe73d 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables > endif > > ifeq ($(CONFIG_THUMB2_KERNEL),y) > -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) > -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) > +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always
Is $(comma) still needed? I thought it was only needed when a flag that would contain commas would be in another set of parens (thus making an ambiguity), like cc-ldoption or such? Can you replace `$(comma)` here with `,`? I suspect it should work.
-- Thanks, ~Nick Desaulniers
| |