Messages in this thread | | | Date | Tue, 5 Mar 2019 07:46:46 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH 3/3] phy: mapphone-mdm6600: add gpiolib dependency |
| |
* Arnd Bergmann <arnd@arndb.de> [190304 20:24]: > gcc points out that when CONFIG_GPIOLIB is disabled, > gpiod_get_array_value_cansleep() returns 0 but fails to set its output: > > drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status': > drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized] > > This could be fixed more generally in gpiolib by returning a failure > code, but for this specific case, the easier workaround is to add a > gpiolib dependency.
Thanks for fixing it:
Acked-by: Tony Lindgren <tony@atomide.com>
| |