Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 5 Mar 2019 09:04:46 +0100 | Subject | Re: [PATCH] media: staging: davinci_vpfe: disallow building with COMPILE_TEST |
| |
Hi Arnd,
On Mon, Mar 4, 2019 at 9:30 PM Arnd Bergmann <arnd@arndb.de> wrote: > The driver should really call dm365_isif_setup_pinmux() through a callback, > but it runs platform specific code by itself, which never actually compiled: > > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2028:2: error: implicit declaration of function 'davinci_cfg_reg' [-Werror,-Wimplicit-function-declaration] > davinci_cfg_reg(DM365_VIN_CAM_WEN); > ^ > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2028:2: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2028:18: error: use of undeclared identifier 'DM365_VIN_CAM_WEN' > davinci_cfg_reg(DM365_VIN_CAM_WEN); > ^ > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2029:18: error: use of undeclared identifier 'DM365_VIN_CAM_VD' > davinci_cfg_reg(DM365_VIN_CAM_VD); > ^ > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2030:18: error: use of undeclared identifier 'DM365_VIN_CAM_HD' > davinci_cfg_reg(DM365_VIN_CAM_HD); > ^ > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2031:18: error: use of undeclared identifier 'DM365_VIN_YIN4_7_EN' > davinci_cfg_reg(DM365_VIN_YIN4_7_EN); > ^ > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:2032:18: error: use of undeclared identifier 'DM365_VIN_YIN0_3_EN' > davinci_cfg_reg(DM365_VIN_YIN0_3_EN); > ^ > 7 errors generated.
Which tree and which config is this? This driver compiles fine with m68k/allmodconfig on v5.0?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |