lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 05/34] c6x: mm: Add p?d_large() definitions
    On Mon, Mar 04, 2019 at 12:01:37PM +0000, Steven Price wrote:
    > On 01/03/2019 21:48, Kirill A. Shutemov wrote:
    > > On Wed, Feb 27, 2019 at 05:05:39PM +0000, Steven Price wrote:
    > >> walk_page_range() is going to be allowed to walk page tables other than
    > >> those of user space. For this it needs to know when it has reached a
    > >> 'leaf' entry in the page tables. This information is provided by the
    > >> p?d_large() functions/macros.
    > >>
    > >> For c6x there's no MMU so there's never a large page, so just add stubs.
    > >
    > > Other option would be to provide the stubs via generic headers form !MMU.
    > >
    >
    > I agree that could be done, but equally the definitions of
    > p?d_present/p?d_none/p?d_bad etc could be provided by a generic header
    > for !MMU but currently are not. It makes sense to keep the p?d_large
    > definitions next to the others.
    >
    > I'd prefer to stick with a (relatively) small change here - it's already
    > quite a long series! But this is certainly something that could be
    > tidied up for !MMU archs.

    Agreed.

    --
    Kirill A. Shutemov

    \
     
     \ /
      Last update: 2019-03-04 14:11    [W:3.273 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site