Messages in this thread | | | Date | Mon, 4 Mar 2019 13:54:37 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH] printk: Remove no longer used LOG_PREFIX. |
| |
On Mon 2019-03-04 11:22:29, Sergey Senozhatsky wrote: > On (02/22/19 18:59), Tetsuo Handa wrote: > > When commit 5becfb1df5ac8e49 ("kmsg: merge continuation records while > > printing") introduced LOG_PREFIX, we used KERN_DEFAULT etc. as a flag > > for setting LOG_PREFIX in order to tell whether to call cont_add() > > (i.e. whether to append the message to "struct cont"). > > > > But since commit 4bcc595ccd80decb ("printk: reinstate KERN_CONT for > > printing continuation lines") inverted the behavior (i.e. don't append > > the message to "struct cont" unless KERN_CONT is specified) and commit > > 5aa068ea4082b39e ("printk: remove games with previous record flags") > > removed the last LOG_PREFIX check, setting LOG_PREFIX via KERN_DEFAULT > > etc. is no longer meaningful. > > > > Therefore, we can remove LOG_PREFIX and make KERN_DEFAULT empty string. > > > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > > Looks good to me. Well, at least I don't see any problems with the patch. > We can do a tree-wide KERN_DEFAULT removal later.
Yup.
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
With a fresh head after the weekend, the patch looks fine and pretty safe to me.
I have pushed it into for-5.1 branch.
Best Regards, Petr
| |