lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] drm/bridge: tc358767: Simplify polling in tc_main_link_setup()
On Tue, Feb 26, 2019 at 11:36:04AM -0800, Andrey Smirnov wrote:
> Replace explicit polling loop with equivalent call to
> regmap_read_poll_timeout() for simplicity. No functional change
> intended.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/gpu/drm/bridge/tc358767.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index c85468fcc157..6455e6484722 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -882,15 +882,11 @@ static int tc_main_link_setup(struct tc_data *tc)
> dp_phy_ctrl &= ~(DP_PHY_RST | PHY_M1_RST | PHY_M0_RST);
> tc_write(DP_PHY_CTRL, dp_phy_ctrl);
>
> - timeout = 1000;
> - do {
> - tc_read(DP_PHY_CTRL, &value);
> - udelay(1);
> - } while ((!(value & PHY_RDY)) && (--timeout));
> -
> - if (timeout == 0) {
> + ret = regmap_read_poll_timeout(tc->regmap, DP_PHY_CTRL, value,
> + value & PHY_RDY, 1, 1000);
> + if (ret) {
> dev_err(dev, "timeout waiting for phy become ready");
> - return -ETIMEDOUT;
> + return ret;
> }
>
> /* Set misc: 8 bits per color */

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2019-03-04 13:29    [W:0.500 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site