Messages in this thread | | | Subject | Re: [PATCH] drm/stm: ltdc: fix data enable polarity | From | Mukesh Ojha <> | Date | Sat, 30 Mar 2019 03:02:41 +0530 |
| |
On 3/29/2019 9:20 PM, Yannick Fertré wrote: > Wrong DISPLAY_FLAGS used to set the data enable polarity. Used or checked? Can you also explain how it is wrong to check against this FLAG in commit? > > Signed-off-by: Yannick Fertré <yannick.fertre@st.com> > --- > drivers/gpu/drm/stm/ltdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index b1741a9..6ba326a 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -555,7 +555,7 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) > if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) > val |= GCR_VSPOL; > > - if (vm.flags & DISPLAY_FLAGS_DE_HIGH) > + if (vm.flags & DISPLAY_FLAGS_DE_LOW) > val |= GCR_DEPOL; > > if (vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
| |