lkml.org 
[lkml]   [2019]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.0 30/67] tools/power turbostat: return the exit status of a command
    Date
    From: David Arcari <darcari@redhat.com>

    [ Upstream commit 2a95496634a017c19641f26f00907af75b962f01 ]

    turbostat failed to return a non-zero exit status even though the
    supplied command (turbostat <command>) failed. Currently when turbostat
    forks a command it returns zero instead of the actual exit status of the
    command. Modify the code to return the exit status.

    Signed-off-by: David Arcari <darcari@redhat.com>
    Acked-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/power/x86/turbostat/turbostat.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
    index 9327c0ddc3a5..c3fad065c89c 100644
    --- a/tools/power/x86/turbostat/turbostat.c
    +++ b/tools/power/x86/turbostat/turbostat.c
    @@ -5077,6 +5077,9 @@ int fork_it(char **argv)
    signal(SIGQUIT, SIG_IGN);
    if (waitpid(child_pid, &status, 0) == -1)
    err(status, "waitpid");
    +
    + if (WIFEXITED(status))
    + status = WEXITSTATUS(status);
    }
    /*
    * n.b. fork_it() does not check for errors from for_all_cpus()
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-30 02:11    [W:3.869 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site