Messages in this thread | | | Subject | Re: [PATCH][next] i40e: Use struct_size() in kzalloc() | From | Jeff Kirsher <> | Date | Fri, 29 Mar 2019 15:36:58 -0700 |
| |
On Thu, 2019-03-28 at 12:52 -0500, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > struct boo entry[]; > }; > > size = sizeof(struct foo) + count * sizeof(struct boo); > instance = kzalloc(size, GFP_KERNEL) > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL) > > Notice that, in this case, variable size is not necessary, hence it > is removed. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/ethernet/intel/i40e/i40e_client.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-)
Thanks Gustavo, I will queue this up. [unhandled content-type:application/pgp-signature] | |