Messages in this thread | | | Date | Thu, 28 Mar 2019 07:06:29 +0000 | From | Daniel Thompson <> | Subject | Re: [PATCH] MIPS: KGDB: fix kgdb support for SMP platforms. |
| |
On Thu, Mar 28, 2019 at 07:08:01AM +0800, Chong Qiao wrote: > KGDB_call_nmi_hook is called by other cpu through smp call. > MIPS smp call is processed in ipi irq handler and regs is saved in > handle_int. > So kgdb_call_nmi_hook get regs by get_irq_regs and regs will be passed > to kgdb_cpu_enter. > > Signed-off-by: Chong Qiao <qiaochong@loongson.cn>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> --- > arch/mips/kernel/kgdb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/kernel/kgdb.c b/arch/mips/kernel/kgdb.c > index 6e574c02e4c3b..ea781b29f7f17 100644 > --- a/arch/mips/kernel/kgdb.c > +++ b/arch/mips/kernel/kgdb.c > @@ -33,6 +33,7 @@ > #include <asm/processor.h> > #include <asm/sigcontext.h> > #include <linux/uaccess.h> > +#include <asm/irq_regs.h> > > static struct hard_trap_info { > unsigned char tt; /* Trap type code for MIPS R3xxx and R4xxx */ > @@ -214,7 +215,7 @@ void kgdb_call_nmi_hook(void *ignored) > old_fs = get_fs(); > set_fs(KERNEL_DS); > > - kgdb_nmicallback(raw_smp_processor_id(), NULL); > + kgdb_nmicallback(raw_smp_processor_id(), get_irq_regs()); > > set_fs(old_fs); > } > -- > 2.17.0 > >
| |