lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] jbd2: remove repeated assignments in __jbd2_log_wait_for_space
On Wed 27-03-19 22:31:35, Liu Song wrote:
> From: Liu Song <liu.song11@zte.com.cn>
>
> At the beginning, nblocks has been assigned. There is no need
> to repeat the assignment in the while loop, and remove it.
>
> Signed-off-by: Liu Song <liu.song11@zte.com.cn>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/jbd2/checkpoint.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
> index 26f8d7e46462..23053de5e999 100644
> --- a/fs/jbd2/checkpoint.c
> +++ b/fs/jbd2/checkpoint.c
> @@ -132,7 +132,6 @@ void __jbd2_log_wait_for_space(journal_t *journal)
> return;
> }
> spin_lock(&journal->j_list_lock);
> - nblocks = jbd2_space_needed(journal);
> space_left = jbd2_log_space_left(journal);
> if (space_left < nblocks) {
> int chkpt = journal->j_checkpoint_transactions != NULL;
> --
> 2.19.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2019-03-27 17:25    [W:0.024 / U:5.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site