[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V4 04/23] perf/x86/intel: Support adaptive PEBSv4
> We need to call perf_event_overflow() for the last record of each event.
> It's hard to detect which record is the last record of the event with one
> pass walking.
> Also, I'm not sure how much we can save with one pass walking. The
> optimization should only benefit large PEBS. The total number of records for
> large PEBS should not be huge.
> I will evaluate the performance impact of one pass walking. If there is
> observed performance improvement, I will submit a separate patch later.
> For now, I think we can still use the mature two pass walking method.

Okay sounds reasonable to keep it then.



 \ /
  Last update: 2019-03-27 15:43    [W:0.049 / U:5.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site