[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/page-flags: Check enforce parameter in PF_ONLY_HEAD()

On 03/27/2019 06:45 PM, Michal Hocko wrote:
> [Cc Nick]
> On Wed 27-03-19 17:57:52, Anshuman Khandual wrote:
>> Just check for enforce parameter in PF_ONLY_HEAD() wrapper before calling
>> VM_BUG_ON_PGFLAGS() for tail pages.
> Why is this an actual fix? Only TESTPAGEFLAG doesn't enforce the check
> but I suspect that Nick just wanted the check to be _always_ performed
> as the name suggests. What kind of problem are you trying to solve?

Did not hit any problem directly. Just from code inspection it seemed that
the enforce check was missing as compared to other wrappers there. I felt
that the commit could have probably omitted the check by mistake.

 \ /
  Last update: 2019-03-27 15:01    [W:0.037 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site