lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers
Hi Simon,

please delete unrelated text. I nearly missed the typo fix later.

> > - if (in_atomic() || irqs_disabled())
> > + if (in_atomic() || irqs_disabled()) {
> > + WARN(!adap->algo->master_xfer_atomic && !adap->algo->smbus_xfer_atomic,
> > + "No atomic I2C transfer handler for '%s'\n", dev_name(&adap->dev));
>
> Is WARN_ONCE more appropriate here?

Why? It could be multiple adapters or clients causing this?

> > + * The return codes from the @master_xfer{_atomic} field should indicate the
>
> I think "field" should be "fields" in the new text.

Fixed, thanks!

Regards,

Wolfram

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-27 14:48    [W:0.026 / U:10.488 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site