Messages in this thread | | | Subject | Re: [PATCH] net: stmmac: fix a potential NULL pointer dereference | From | Mukesh Ojha <> | Date | Wed, 27 Mar 2019 19:12:29 +0530 |
| |
On 3/12/2019 1:02 PM, Kangjie Lu wrote: > In case of_device_get_match_data fails, the fix return -ENOMEM
s/-ENOMEM/-EINVAL
Otherwise looks good to me. Make the above correction. Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> to avoid the NULL pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > index 3256e5cbad27..344ead5949b1 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > @@ -485,6 +485,8 @@ static int dwc_eth_dwmac_remove(struct platform_device *pdev) > int err; > > data = of_device_get_match_data(&pdev->dev); > + if (!data) > + return -EINVAL; > > err = stmmac_dvr_remove(&pdev->dev); > if (err < 0)
| |