Messages in this thread | | | Subject | Re: [PATCH v2 1/2] powerpc: Make some functions static | From | Mukesh Ojha <> | Date | Wed, 27 Mar 2019 18:10:12 +0530 |
| |
On 3/27/2019 2:17 AM, Mathieu Malaterre wrote: > In commit cb9e4d10c448 ("[POWERPC] Add support for 750CL Holly board") > new functions were added. Since most of these functions can be made static, > make it so. > > Both holly_power_off and holly_halt functions were not changed since they > are unused, making them static would have triggered the following warning > (treated as error): > > arch/powerpc/platforms/embedded6xx/holly.c:244:13: error: 'holly_halt' defined but not used [-Werror=unused-function] > > Silence the following warnings triggered using W=1: > > arch/powerpc/platforms/embedded6xx/holly.c:47:5: error: no previous prototype for 'holly_exclude_device' [-Werror=missing-prototypes] > arch/powerpc/platforms/embedded6xx/holly.c:190:6: error: no previous prototype for 'holly_show_cpuinfo' [-Werror=missing-prototypes] > arch/powerpc/platforms/embedded6xx/holly.c:196:17: error: no previous prototype for 'holly_restart' [-Werror=missing-prototypes] > > Signed-off-by: Mathieu Malaterre <malat@debian.org>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> --- > v2: Split the patch in two operations > > arch/powerpc/platforms/embedded6xx/holly.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/embedded6xx/holly.c b/arch/powerpc/platforms/embedded6xx/holly.c > index 0409714e8070..9d2eefef7b7b 100644 > --- a/arch/powerpc/platforms/embedded6xx/holly.c > +++ b/arch/powerpc/platforms/embedded6xx/holly.c > @@ -44,7 +44,8 @@ > > #define HOLLY_PCI_CFG_PHYS 0x7c000000 > > -int holly_exclude_device(struct pci_controller *hose, u_char bus, u_char devfn) > +static int holly_exclude_device(struct pci_controller *hose, u_char bus, > + u_char devfn) > { > if (bus == 0 && PCI_SLOT(devfn) == 0) > return PCIBIOS_DEVICE_NOT_FOUND; > @@ -187,13 +188,13 @@ static void __init holly_init_IRQ(void) > tsi108_write_reg(TSI108_MPIC_OFFSET + 0x30c, 0); > } > > -void holly_show_cpuinfo(struct seq_file *m) > +static void holly_show_cpuinfo(struct seq_file *m) > { > seq_printf(m, "vendor\t\t: IBM\n"); > seq_printf(m, "machine\t\t: PPC750 GX/CL\n"); > } > > -void __noreturn holly_restart(char *cmd) > +static void __noreturn holly_restart(char *cmd) > { > __be32 __iomem *ocn_bar1 = NULL; > unsigned long bar;
| |