lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro
On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote:
> Replace verbose implementation in set_multiple callback with
> for_each_set_clump8 macro to simplify code and improve clarity.

> + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) {

> + bank = (chip->registers - 1) - (offset / 8);

Excessive parens, but it's minor.

> + bitmask = bitmap_get_value8(bits, offset) & bankmask;
>
> chip->buffer[bank] &= ~bankmask;
> + chip->buffer[bank] |= bitmask;
> }

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-03-27 13:34    [W:0.088 / U:23.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site