lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v5 08/22] ethtool: support for netlink notifications
    Wed, Mar 27, 2019 at 10:51:48AM CET, andrew@lunn.ch wrote:
    >On Wed, Mar 27, 2019 at 10:38:43AM +0100, Jiri Pirko wrote:
    >> Tue, Mar 26, 2019 at 07:17:20PM CET, mkubecek@suse.cz wrote:
    >> >On Tue, Mar 26, 2019 at 05:34:00PM +0100, Jiri Pirko wrote:
    >> >> Mon, Mar 25, 2019 at 06:08:18PM CET, mkubecek@suse.cz wrote:
    >> >> >+void ethtool_notify(struct net_device *dev, struct netlink_ext_ack *extack,
    >> >> >+ unsigned int cmd, u32 req_mask, const void *data)
    >> >> >+{
    >> >> >+ if (unlikely(!ethnl_ok))
    >> >>
    >> >> Why do you need this?
    >> >
    >> >If genetlink family registration fails, ethtool_notify() can be still
    >> >called from other code (e.g. the ethtool ioctl interface). In such case,
    >> >better bail out right away than fail somewhere later (probably after
    >> >preparing the message which can't be sent anyway).
    >>
    >> Again, haven't seen this in any other gen netlink implementation. Why do
    >> they not need it?
    >
    >Hi Jiri
    >
    >All other gen netlink kill the machine dead if they cannot register

    Wait, what do you mean be "kill the machine dead"?

    >the socket.

    Example:
    static int __init devlink_init(void)
    {
    return genl_register_family(&devlink_nl_family);
    }

    \
     
     \ /
      Last update: 2019-03-27 11:05    [W:4.436 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site