lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs
On Thu, 28 Mar 2019 02:12:15 +0300
"Dmitry V. Levin" <ldv@altlinux.org> wrote:

> > Seriously. If we keep it can we at least remove all the unused arguments
> > which we have on both functions to simplify the whole mess?
>
> In case of syscall_set_arguments() I think we can safely remove
> "i" and "n" arguments assuming i == 0 and n == 6.
>
> All I can say about syscall_get_arguments() is that
> - all current users invoke it with i == 0,
> - all current users that invoke it with n != 6 are in kernel/trace/trace_syscalls.c
> so it may actually be invoked with n < 6.

Yes, that's what my old (and current) patches address. I removed the
i,n parameters and make it 0,6 hardcoded in the routines.

Patches will be out soon.

-- Steve

\
 
 \ /
  Last update: 2019-03-28 00:15    [W:0.047 / U:10.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site