lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.0 200/262] bpf: fix missing prototype warnings
    Date
    From: Valdis Kletnieks <valdis.kletnieks@vt.edu>

    [ Upstream commit 116bfa96a255123ed209da6544f74a4f2eaca5da ]

    Compiling with W=1 generates warnings:

    CC kernel/bpf/core.o
    kernel/bpf/core.c:721:12: warning: no previous prototype for ?bpf_jit_alloc_exec_limit? [-Wmissing-prototypes]
    721 | u64 __weak bpf_jit_alloc_exec_limit(void)
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    kernel/bpf/core.c:757:14: warning: no previous prototype for ?bpf_jit_alloc_exec? [-Wmissing-prototypes]
    757 | void *__weak bpf_jit_alloc_exec(unsigned long size)
    | ^~~~~~~~~~~~~~~~~~
    kernel/bpf/core.c:762:13: warning: no previous prototype for ?bpf_jit_free_exec? [-Wmissing-prototypes]
    762 | void __weak bpf_jit_free_exec(void *addr)
    | ^~~~~~~~~~~~~~~~~

    All three are weak functions that archs can override, provide
    proper prototypes for when a new arch provides their own.

    Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
    Acked-by: Song Liu <songliubraving@fb.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/filter.h | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/include/linux/filter.h b/include/linux/filter.h
    index e532fcc6e4b5..3358646a8e7a 100644
    --- a/include/linux/filter.h
    +++ b/include/linux/filter.h
    @@ -874,7 +874,9 @@ bpf_jit_binary_alloc(unsigned int proglen, u8 **image_ptr,
    unsigned int alignment,
    bpf_jit_fill_hole_t bpf_fill_ill_insns);
    void bpf_jit_binary_free(struct bpf_binary_header *hdr);
    -
    +u64 bpf_jit_alloc_exec_limit(void);
    +void *bpf_jit_alloc_exec(unsigned long size);
    +void bpf_jit_free_exec(void *addr);
    void bpf_jit_free(struct bpf_prog *fp);

    int bpf_jit_get_func_addr(const struct bpf_prog *prog,
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-27 20:18    [W:8.682 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site