lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723bs: core: fix line over 80 characters warning
On Tue, Mar 26, 2019 at 11:55:07PM +0530, Anirudh Rayabharam wrote:
> Shorten the expression by re-using the part that was already computed to

This confused me. Better to phrase it like:

Shorten the expression by using the "psecuritypriv" pointer.

> fix the line over 80 characters warning reported by checkpatch.pl.
>
> Signed-off-by: Anirudh Rayabharam <anirudh.rayabharam@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 18fabf5ff44b..bc0230672457 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
> Update_RA_Entry(padapter, psta);
> /* pairwise key */
> /* per sta pairwise key and settings */
> - if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> - (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> + if ((psecuritypriv->dot11PrivacyAlgrthm == _TKIP_) ||
> + (psecuritypriv->dot11PrivacyAlgrthm == _AES_)) {

It's better to align it slightly different as well. In the kernel we
would normally align the second condition to match the first one.

I probably would have gotten rid of the parenthesis as well. I don't
like double parenthesis around == because I reserve that for =
assignment conditions.

if (psecuritypriv->dot11PrivacyAlgrthm == _TKIP_ ||
psecuritypriv->dot11PrivacyAlgrthm == _AES_) {
rtw_setstakey_cmd(padapter, psta, true, false);

When you're changing just a couple lines like this you can get away with
making multiple white space changes at the same time because the One
Thing that the patch does is "Clean up a Condition". There is some
flexibility in the One thing Per Patch rule, but you have to sell it in
the right way. The patch description would be:

Checkpatch.pl complains that this line is over 80 characters. We
should use the "psecuritypriv" for consistency. It's not aligned
properly and there are too many parenthesis.

This patch just cleans up a condition, it doesn't affect runtime.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-03-27 07:37    [W:0.105 / U:12.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site