lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 1/2] net: phy: mscc: add support for VSC8514 PHY
From
From: <Kavyasree.Kotagiri@microchip.com>
Date: Wed, 27 Mar 2019 09:56:13 +0000

> +static u32 vsc85xx_csr_ctrl_phy_read(struct phy_device *phydev,
> + u32 target, u32 reg)
> +{
> + u32 val, val_l, val_h;
> + unsigned long deadline;

Please order local variable declarations from longest to shortest
line, ie. reverse christmas tree.

> +static int vsc8514_config_init(struct phy_device *phydev)
> +{
> + int ret, i;
> + u16 val, addr;
> + u32 reg;
> + unsigned long deadline;
> + struct vsc8531_private *vsc8531 = phydev->priv;

Likewise.

\
 
 \ /
  Last update: 2019-03-27 19:30    [W:0.024 / U:7.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site