lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 23/45] ALSA: x86: Fix runtime PM for hdmi-lpe-audio
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ville Syrjälä <ville.syrjala@linux.intel.com>

    commit 8dfb839cfe737a17def8e5f88ee13c295230364a upstream.

    Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
    "no callbacks"") broke runtime PM with lpe audio. We can no longer
    runtime suspend the GPU since the sysfs power/control for the
    lpe-audio device no longer exists and the device is considered
    always active. We can fix this by not marking the device as
    active.

    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Takashi Iwai <tiwai@suse.de>
    Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181024154825.18185-1-ville.syrjala@linux.intel.com
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Acked-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/x86/intel_hdmi_audio.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/sound/x86/intel_hdmi_audio.c
    +++ b/sound/x86/intel_hdmi_audio.c
    @@ -1900,7 +1900,6 @@ static int hdmi_lpe_audio_probe(struct p

    pm_runtime_use_autosuspend(&pdev->dev);
    pm_runtime_mark_last_busy(&pdev->dev);
    - pm_runtime_set_active(&pdev->dev);

    dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
    for_each_port(card_ctx, port) {

    \
     
     \ /
      Last update: 2019-03-26 07:44    [W:2.360 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site