lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.
On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote:
> This is the dev_xxx() analog to print_hex_dump(), using dev_printk()
> instead of straight printk() to match other dev_xxx() logging functions.
> ---
> drivers/base/core.c | 43 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/device.h | 15 +++++++++++++++
> 2 files changed, 58 insertions(+)

No signed-off-by?

Anyway, no, please do not do this. Please do not dump large hex values
like this to the kernel log, it does not help anyone.

You can do this while debugging, sure, but not for "real" kernel code.

Worst case, just create a debugfs file for your device that you can read
the binary data from if you really need it. For any "normal" operation,
this is not something that you should ever need.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-03-27 03:39    [W:0.125 / U:4.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site