[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v3 0/4] Add Apple SPI keyboard and trackpad driver
This changeset adds a driver for the SPI keyboard and trackpad on recent
MacBook's and MacBook Pro's. The driver has seen a fair amount of use
over the last 2 years (basically anybody running linux on these
machines), with only relatively small changes in the last year or so.
For those interested, the driver development has been hosted at (as well as my clone at

The first patch is just a placeholder for now and is provided in case
somebody wants to compile the driver while it's being reviewed here; the
real patch has been submitted to dri-devel and is being discussed there,
with the intent/hope that I can get an Ack and permission to merge it
through the input subsystem tree here as part of this patch series.

The second and third patches add a new dev_print_hex_dump() helper as
the dev_xxx() analog of print_hex_dump().

The fourth patch finally contains the new applespi driver.

Changes in v3:
Applied all feedback from review by Andy Shevchenko, including:
- move dev_print_hex_dump() to driver core
- clean up keyboard modifier bits testing/modifying
- remove DEV() macro
- minor style issues
The full set of changes to applespi can be viewed at as individual
commits f832caa..3a6262e in the upstreaming-review branch.

Ronald Tschalär (4):
drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.
lib/hexdump.c: factor out generic hexdump formatting for reuse.
driver core: add dev_print_hex_dump() logging function.
Input: add Apple SPI keyboard and trackpad driver.

drivers/base/core.c | 43 +
drivers/gpu/drm/bridge/Kconfig | 2 +-
drivers/input/keyboard/Kconfig | 15 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/applespi.c | 1988 +++++++++++++++++++++++++++++
include/linux/device.h | 15 +
include/linux/printk.h | 12 +
lib/hexdump.c | 95 +-
8 files changed, 2146 insertions(+), 25 deletions(-)
create mode 100644 drivers/input/keyboard/applespi.c


 \ /
  Last update: 2019-03-27 02:48    [W:0.166 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site