lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] tools/lib/traceevent: rename input arguments of libtraceevent APIs from pevent to tep
On Tue, 26 Mar 2019 15:57:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 26 Mar 2019 17:43:24 +0200
> Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
>
> > This patch renames "struct tep_handle *pevent" input arguments of libtraceevent
> > APIs to "struct tep_handle *tep". This makes the API consistent with the chosen
> > naming convention: tep (trace event parser), instead of the old pevent.
> >
> > Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
>
> I have no problems with this patch, but as I didn't apply some of the
> earlier patches, this one doesn't apply, so you will need to send it
> again in the next series.

Oh, I do have one issue. Don't forget to capitalize the first word in
the subject. "s/rename input/Rename input/"

That goes with the other patches as well.

-- Steve

\
 
 \ /
  Last update: 2019-03-26 20:59    [W:0.369 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site