lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex
On Mon, Mar 25, 2019 at 11:49 AM John Garry <john.garry@huawei.com> wrote:
> On 23/03/2019 19:12, Andy Shevchenko wrote:
> > On Wed, Mar 20, 2019 at 8:14 PM John Garry <john.garry@huawei.com> wrote:
> >>
> >> Some prints in the code are for a hex number, but don't prefix "0x". Add
> >> the prefix, as is the norm.
> >
> >> - pr_err("addr %llx not registered in io_range_list\n",
> >> + pr_err("addr 0x%llx not registered in io_range_list\n",
> >> (unsigned long long) addr);
> >
> > Can we use %pa at the same time?

> OK, I think that we can use %pa and drop the casting to unsigned long long.

Yes, that it is the point.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-03-25 16:05    [W:0.043 / U:1.692 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site