lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
From
Date

On 3/23/2019 7:38 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add


I am not able to find this commit

0580dde59438


> asoc_simple_debug_info()"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/soc/generic/simple-card-utils.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 4ed68348f939..db1458a19985 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
> * see
> * soc-core.c :: snd_soc_init_multicodec()
> */
> - if (dlc) {
> + if (dlc)
> dai_of_node = dlc->of_node;
> - dai_name = dlc->dai_name;

I don't see any function like `asoc_simple_parse_clk`

but instead this `asoc_simple_card_parse_clk` and there the variable is
used.

Can you double check latest code base ?

Thanks,
Mukesh


> - }
>
> /*
> * Parse dai->sysclk come from "clocks = <&xxx>"
>
>
>
>
>

\
 
 \ /
  Last update: 2019-03-25 08:42    [W:0.100 / U:29.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site