lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] net: liquidio: fix NULL pointer dereferences
From
From: Kangjie Lu <kjlu@umn.edu>
Date: Fri, 22 Mar 2019 22:24:19 -0500

> In case octeon_alloc_soft_command fails, the fix reports the
> error and goes to cleanup to avoid NULL pointer dereferences.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> V2: goto setup_nic_dev_free for cleanup
> ---
> drivers/mmc/host/mmc_spi.c | 2 +-
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 32fea585262b..a3533935e282 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -820,7 +820,7 @@ mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
>
> status = spi_sync_locked(spi, &host->m);
> if (status < 0) {
> - dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
> + dev_dbg(&spi->dev, "read error %d\n", status);
> return status;
> }

This is:

1) Unrelated to your bug fix.

2) It is often the case that people print values in hex and decimal
intentionally for debugging. I've done this myself countless
times.

\
 
 \ /
  Last update: 2019-03-26 01:14    [W:0.311 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site