lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/14] bus: ti-sysc: Fix sysc_unprepare() when no clocks have been allocated
    Date
    If we return early before ddata->clocks have been allocated we will get a
    NULL pointer dereference in sysc_unprepare(). Let's fix this by returning
    early when no clocks are allocated.

    Fixes: 0eecc636e5a2 ("bus: ti-sysc: Add minimal TI sysc interconnect target driver")
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    ---
    drivers/bus/ti-sysc.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
    --- a/drivers/bus/ti-sysc.c
    +++ b/drivers/bus/ti-sysc.c
    @@ -1331,6 +1331,9 @@ static void sysc_unprepare(struct sysc *ddata)
    {
    int i;

    + if (!ddata->clocks)
    + return;
    +
    for (i = 0; i < SYSC_MAX_CLOCKS; i++) {
    if (!IS_ERR_OR_NULL(ddata->clocks[i]))
    clk_unprepare(ddata->clocks[i]);
    --
    2.21.0
    \
     
     \ /
      Last update: 2019-03-25 23:01    [W:2.332 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site